Skip to content

FELIX-6776 introduce way to restrict request and response size #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

paulrutter
Copy link
Contributor

paulrutter added 5 commits May 7, 2025 14:39
- Introducing two new config properties, `org.apache.felix.http.jetty.requestSizeLimit` and `org.apache.felix.http.jetty.responseSizeLimit`
- If either one is configured, the SizeLimitHandler will be configured
- -1 is the default, which means unlimited
- Do we still need to set `setMaxFormContentSize` now?
- Updated README.md
# Conflicts:
#	http/jetty12/src/test/java/org/apache/felix/http/jetty/it/JettyMaxFormSizeIT.java
- introduce org.apache.felix.http.jetty.requestSizeLimit and org.apache.felix.http.jetty.responseSizeLimit
- If either one is configured, the SizeLimitHandler will be configured, see https://jetty.org/docs/jetty/12/programming-guide/server/http.html#handler-use-size-limit
- -1 is the default for both, which means unlimited.
- Updated README.md for new properties
@paulrutter paulrutter requested a review from cziegeler May 7, 2025 18:16
@paulrutter paulrutter changed the title Maintenance/felix 6776 introduce way to restrict request and response size FELIX-6776 introduce way to restrict request and response size May 7, 2025
- Upgrade mockito to try and resolve the mockito issue on Java 23
- Upgrade test scope dependency of Jetty to 12.0.19
- Revert byte-buddy as it doesn't fix 23
Copy link
Contributor

@cziegeler cziegeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks

…strict-request-and-response-size

# Conflicts:
#	http/base/pom.xml
@paulrutter paulrutter merged commit 8834049 into master May 13, 2025
2 of 3 checks passed
@paulrutter paulrutter deleted the maintenance/FELIX-6776-Introduce-way-to-restrict-request-and-response-size branch May 13, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants